Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support fasta.gz in GATKSparkTool #5290

Merged
merged 1 commit into from
Oct 9, 2018
Merged

Support fasta.gz in GATKSparkTool #5290

merged 1 commit into from
Oct 9, 2018

Conversation

tomwhite
Copy link
Contributor

@tomwhite tomwhite commented Oct 8, 2018

Fixes #5258

@codecov-io
Copy link

Codecov Report

Merging #5290 into master will increase coverage by <.01%.
The diff coverage is 100%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master    #5290      +/-   ##
============================================
+ Coverage     86.77%   86.77%   +<.01%     
  Complexity    29888    29888              
============================================
  Files          1834     1834              
  Lines        138473   138479       +6     
  Branches      15241    15242       +1     
============================================
+ Hits         120162   120170       +8     
+ Misses        12760    12758       -2     
  Partials       5551     5551
Impacted Files Coverage Δ Complexity Δ
...stitute/hellbender/engine/spark/GATKSparkTool.java 82.19% <100%> (+0.37%) 68 <0> (ø) ⬇️
...ls/spark/BaseRecalibratorSparkIntegrationTest.java 40.54% <100%> (+1.09%) 5 <0> (ø) ⬇️
...va/org/broadinstitute/hellbender/GATKBaseTest.java 100% <100%> (ø) 7 <0> (ø) ⬇️
...e/hellbender/engine/spark/SparkContextFactory.java 73.97% <0%> (+2.73%) 11% <0%> (ø) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 158f7f7...2cb7fd4. Read the comment docs.

@droazen droazen requested review from droazen and removed request for lbergelson October 9, 2018 16:52
@droazen droazen self-assigned this Oct 9, 2018
Copy link
Member

@lbergelson lbergelson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@tomwhite Thank you. This looks good to me.

@lbergelson lbergelson merged commit 2880ddd into master Oct 9, 2018
@lbergelson lbergelson deleted the tw_spark_fasta.gz branch October 9, 2018 20:24
EdwardDixon pushed a commit to EdwardDixon/gatk that referenced this pull request Nov 9, 2018
* fasta.gz references can now be used in GATKSparkTools
* fixes broadinstitute#5258
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants