Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add full-sized B37 and HG38 references to our large test data #5309

Merged
merged 1 commit into from
Oct 16, 2018

Conversation

droazen
Copy link
Collaborator

@droazen droazen commented Oct 15, 2018

Resolves #5111

@droazen
Copy link
Collaborator Author

droazen commented Oct 15, 2018

@jonn-smith and @lbergelson please review

@codecov-io
Copy link

Codecov Report

Merging #5309 into master will increase coverage by <.001%.
The diff coverage is 83.333%.

@@              Coverage Diff               @@
##             master     #5309       +/-   ##
==============================================
+ Coverage     86.78%   86.781%   +<.001%     
- Complexity    30001     30004        +3     
==============================================
  Files          1838      1838               
  Lines        139051    139063       +12     
  Branches      15329     15331        +2     
==============================================
+ Hits         120669    120680       +11     
+ Misses        12809     12807        -2     
- Partials       5573      5576        +3
Impacted Files Coverage Δ Complexity Δ
...va/org/broadinstitute/hellbender/GATKBaseTest.java 100% <100%> (ø) 7 <0> (ø) ⬇️
...hellbender/engine/ReferenceDataSourceUnitTest.java 71.739% <80%> (+2.295%) 11 <2> (+2) ⬆️
...nder/utils/runtime/StreamingProcessController.java 71.564% <0%> (-0.948%) 37% <0%> (-1%)
...ithwaterman/SmithWatermanIntelAlignerUnitTest.java 60% <0%> (ø) 2% <0%> (ø) ⬇️
...utils/smithwaterman/SmithWatermanIntelAligner.java 80% <0%> (+30%) 3% <0%> (+2%) ⬆️

Copy link
Collaborator

@jonn-smith jonn-smith left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

👍

Copy link
Member

@lbergelson lbergelson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. Could you open a new issue to audit the existing large files and remove ones that are now redundant since we've included the whole references?

@droazen
Copy link
Collaborator Author

droazen commented Oct 16, 2018

@lbergelson Opened #5313

@droazen droazen merged commit 6fa95a8 into master Oct 16, 2018
@droazen droazen deleted the dr_full_sized_test_references branch October 16, 2018 16:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants