Funcotator - VCF ID for VCF Data Sources #5327
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jonn-smith
changed the title
jonn-smith
force-pushed
the
jts_VCF_IDs_In_Funcotations_5186
branch
from
c572a32
to
8aaac8c
Compare
|
@LeeTL1220 Ready for review now. |
Codecov Report
@@ Coverage Diff @@
## master #5327 +/- ##
===============================================
+ Coverage 86.903% 86.905% +0.002%
- Complexity 30309 30313 +4
===============================================
Files 1849 1849
Lines 140501 140507 +6
Branches 15475 15475
===============================================
+ Hits 122100 122108 +8
+ Misses 12792 12790 -2
Partials 5609 5609
|
LeeTL1220
approved these changes
Oct 25, 2018
There was a problem hiding this comment.
@jonn-smith Minor changes. Address then feel free to merge.
...va/org/broadinstitute/hellbender/tools/funcotator/dataSources/vcf/VcfFuncotationFactory.java
Outdated
Show resolved
Hide resolved
...va/org/broadinstitute/hellbender/tools/funcotator/dataSources/vcf/VcfFuncotationFactory.java
Show resolved
Hide resolved
...va/org/broadinstitute/hellbender/tools/funcotator/dataSources/vcf/VcfFuncotationFactory.java
Outdated
Show resolved
Hide resolved
...roadinstitute/hellbender/tools/funcotator/dataSources/vcf/VcfFuncotationFactoryUnitTest.java
Outdated
Show resolved
Hide resolved
EdwardDixon
pushed a commit
to EdwardDixon/gatk
that referenced
this pull request
Nov 9, 2018
Implemented VCF ID for VCF data sources. - Now VCF data sources create an ID field for the ID of the variant used for the annotation. - Updated the regression test suite with a VCF data source to increase test coverage. Fixes broadinstitute#5186
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implemented VCF ID for VCF data sources.
Now VCF data sources create an ID field for the ID of the variant
used for the annotation.
Updated the regression test suite with a VCF data source to increase
test coverage.
Fixes #5186