Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removing WellformedReadFilter from CountReadsSpark #5329

Merged
merged 1 commit into from
Oct 19, 2018

Conversation

jamesemery
Copy link
Collaborator

I have been burned one too many times by the fact that this count silently filters reads for you. Since there is no logging output printing the number of filtered reads in spark it makes more sense to remove filtering from the tool altogether.

Copy link
Member

@lbergelson lbergelson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This make sense to me.

@codecov-io
Copy link

Codecov Report

Merging #5329 into master will decrease coverage by 1.16%.
The diff coverage is 100%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master    #5329      +/-   ##
============================================
- Coverage     86.79%   85.62%   -1.17%     
+ Complexity    30124    29844     -280     
============================================
  Files          1843     1843              
  Lines        139480   139481       +1     
  Branches      15376    15376              
============================================
- Hits         121060   119433    -1627     
- Misses        12827    14515    +1688     
+ Partials       5593     5533      -60
Impacted Files Coverage Δ Complexity Δ
...lbender/tools/spark/pipelines/CountReadsSpark.java 90.9% <100%> (+0.9%) 5 <1> (+1) ⬆️
...s/GermlineContigPloidyModelArgumentCollection.java 0% <0%> (-100%) 0% <0%> (-4%)
...mlineContigPloidyHybridADVIArgumentCollection.java 0% <0%> (-100%) 0% <0%> (-3%)
...er/utils/python/PythonScriptExecutorException.java 0% <0%> (-100%) 0% <0%> (-1%)
...ments/GermlineCNVHybridADVIArgumentCollection.java 0% <0%> (-100%) 0% <0%> (-3%)
...r/arguments/GermlineCallingArgumentCollection.java 0% <0%> (-100%) 0% <0%> (-4%)
...tools/examples/ExampleStreamingPythonExecutor.java 0% <0%> (-96.67%) 0% <0%> (-8%)
.../walkers/vqsr/CNNScoreVariantsIntegrationTest.java 4.16% <0%> (-95.84%) 2% <0%> (-8%)
...der/utils/python/PythonScriptExecutorUnitTest.java 3.84% <0%> (-94.24%) 1% <0%> (-11%)
...number/arguments/HybridADVIArgumentCollection.java 0% <0%> (-94.12%) 0% <0%> (-3%)
... and 36 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f95b6fe...1c00f72. Read the comment docs.

@jamesemery jamesemery merged commit ec59e1e into master Oct 19, 2018
@jamesemery jamesemery deleted the je_removeFilterFromCountReadsSpark branch October 19, 2018 14:04
EdwardDixon pushed a commit to EdwardDixon/gatk that referenced this pull request Nov 9, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants