Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Now correctly populates transcript position. #5380

Merged
merged 2 commits into from
Oct 31, 2018

Conversation

jonn-smith
Copy link
Collaborator

Before the transcript position would always only be the start position
of the variant in the transcript.

The transcript position field should contain either a single number (for
SNPS) or two numbers separated by an underscore representing the
transcript start and stop positions of the variant.

This fix correctly changes the field to include both start and stop
positions when start != stop.

Fixes #5375

Before the transcript position would always only be the start position
of the variant in the transcript.

The transcript position field should contain either a single number (for
    SNPS) or two numbers separated by an underscore representing the
transcript start and stop positions of the variant.

This fix correctly changes the field to include both start and stop
positions when start != stop.

Fixes #5375
Copy link
Contributor

@LeeTL1220 LeeTL1220 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jonn-smith Feel free to merge if tests pass

@jonn-smith jonn-smith merged commit c3d3b01 into master Oct 31, 2018
@jonn-smith jonn-smith deleted the jts_tx_position_fix_5375 branch October 31, 2018 21:31
EdwardDixon pushed a commit to EdwardDixon/gatk that referenced this pull request Nov 9, 2018
* Now correctly populates transcript position.

Before the transcript position would always only be the start position
of the variant in the transcript.

The transcript position field should contain either a single number (for
    SNPS) or two numbers separated by an underscore representing the
transcript start and stop positions of the variant.

This fix correctly changes the field to include both start and stop
positions when start != stop.

Fixes broadinstitute#5375
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Transcript position is not quite correct
2 participants