Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated testing Gencode data sources to fully exercise test data set #5423

Merged
merged 2 commits into from
Nov 16, 2018

Conversation

jonn-smith
Copy link
Collaborator

The test Gencode data sources did not include any genes in flanking distance to the test variants. This update creates a new Gencode data source that includes such regions.

Additionally, the Gencode excision script was updated to include a flanking range defaulting to the funcotator 5' flanking defualt (5000 bases).

Fixes #5419

Updated the run_oncotator_VCF_in.sh script to point at the new
regression test data source locations by default.
- Updated `createSimpleGencodeDataSourceFromVariants.sh` to grab
flanking genes as well as overlapping genes.
Copy link
Member

@lbergelson lbergelson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This seems sane to me. I didn't do a proper review of the bash script because:
A) my reviews of bash scripts aren't particularly useful
2) it's experimental and tied to your computer in some way

@jonn-smith jonn-smith merged commit 52058ed into master Nov 16, 2018
@jonn-smith jonn-smith deleted the jts_datasources_fix_5419 branch November 16, 2018 21:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants