Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add description getter to GATKReportTable #5443

Merged
merged 2 commits into from
Nov 26, 2018
Merged

Add description getter to GATKReportTable #5443

merged 2 commits into from
Nov 26, 2018

Conversation

bbimber
Copy link
Contributor

@bbimber bbimber commented Nov 22, 2018

This PR is a simple addition to add GATKReportTable.getDescription(), to allow other classes to get the value of description.

@codecov-io
Copy link

codecov-io commented Nov 22, 2018

Codecov Report

Merging #5443 into master will decrease coverage by 0.209%.
The diff coverage is 0%.

@@               Coverage Diff               @@
##              master     #5443       +/-   ##
===============================================
- Coverage     87.007%   86.798%   -0.209%     
+ Complexity     31175     31089       -86     
===============================================
  Files           1908      1908               
  Lines         144007    144008        +1     
  Branches       15927     15927               
===============================================
- Hits          125296    124996      -300     
- Misses         12954     13286      +332     
+ Partials        5757      5726       -31
Impacted Files Coverage Δ Complexity Δ
...itute/hellbender/utils/report/GATKReportTable.java 70.412% <0%> (-0.265%) 67 <0> (ø)
...ils/nio/NioFileCopierWithProgressMeterResults.java 0% <0%> (-94.737%) 0% <0%> (-9%)
...s/spark/ParallelCopyGCSDirectoryIntoHDFSSpark.java 0% <0%> (-74.257%) 0% <0%> (-17%)
...nder/tools/spark/pipelines/PrintVariantsSpark.java 0% <0%> (-66.667%) 0% <0%> (-2%)
...ols/funcotator/FuncotatorDataSourceDownloader.java 0% <0%> (-66.197%) 0% <0%> (-14%)
...nder/utils/nio/NioFileCopierWithProgressMeter.java 17% <0%> (-52.5%) 9% <0%> (-30%)
...oadinstitute/hellbender/utils/gcs/BucketUtils.java 58.537% <0%> (-21.951%) 33% <0%> (-9%)
...der/engine/spark/datasources/ReadsSparkSource.java 77.083% <0%> (-3.125%) 31% <0%> (ø)
...adinstitute/hellbender/engine/ReadsDataSource.java 89.394% <0%> (-3.03%) 61% <0%> (-2%)
...te/hellbender/engine/spark/VariantWalkerSpark.java 72.727% <0%> (-2.273%) 14% <0%> (ø)
... and 4 more

Copy link
Collaborator

@cmnbroad cmnbroad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Simple enough, but two minor changes requested.

@@ -664,4 +664,8 @@ public boolean equals(final GATKReportTable table) {
return underlyingData;
}
}

public String getTableDescription() {
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please move this so its up next to the other getters, and add javadoc.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done. since we're adding javadoc to one getter, i added it to all the others (which didnt have it). are you OK squashing when merging?

Copy link
Collaborator

@cmnbroad cmnbroad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good - thx for the javadoc!

@cmnbroad cmnbroad merged commit 3941772 into broadinstitute:master Nov 26, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants