Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix LeftAlignAndTrimVariants args. #5519

Merged
merged 1 commit into from
Jan 3, 2019
Merged

Fix LeftAlignAndTrimVariants args. #5519

merged 1 commit into from
Jan 3, 2019

Conversation

cmnbroad
Copy link
Collaborator

Fix for #5511, intermittent LeftAlignAndTrimVariants unit tests failures.

@codecov-io
Copy link

Codecov Report

Merging #5519 into master will increase coverage by 0.035%.
The diff coverage is 100%.

@@              Coverage Diff               @@
##             master     #5519       +/-   ##
==============================================
+ Coverage     87.07%   87.105%   +0.035%     
- Complexity    31318     31481      +163     
==============================================
  Files          1921      1921               
  Lines        144566    145124      +558     
  Branches      15950     16048       +98     
==============================================
+ Hits         125874    126410      +536     
- Misses        12900     12922       +22     
  Partials       5792      5792
Impacted Files Coverage Δ Complexity Δ
...variantutils/LeftAlignAndTrimVariantsUnitTest.java 100% <100%> (ø) 21 <0> (ø) ⬇️
...walkers/variantutils/LeftAlignAndTrimVariants.java 93.197% <100%> (ø) 39 <0> (-1) ⬇️
...r/tools/walkers/mutect/Mutect2IntegrationTest.java 94.466% <0%> (-0.016%) 75% <0%> (+3%)
.../tools/walkers/annotator/ReadPositionUnitTest.java 100% <0%> (ø) 5% <0%> (ø) ⬇️
...ls/walkers/mutect/M2FiltersArgumentCollection.java 100% <0%> (ø) 2% <0%> (+1%) ⬆️
...oadinstitute/hellbender/utils/gcs/BucketUtils.java 81.098% <0%> (+0.61%) 42% <0%> (ø) ⬇️
...der/tools/walkers/mutect/M2ArgumentCollection.java 89.13% <0%> (+1.63%) 14% <0%> (+5%) ⬆️
...er/tools/funcotator/FuncotatorIntegrationTest.java 85.971% <0%> (+1.669%) 180% <0%> (+69%) ⬆️
...itute/hellbender/tools/walkers/mutect/Mutect2.java 84% <0%> (+1.778%) 27% <0%> (+3%) ⬆️
...tools/walkers/haplotypecaller/graphs/SeqGraph.java 89.412% <0%> (+2.353%) 24% <0%> (+1%) ⬆️
... and 7 more

Copy link
Collaborator

@jamesemery jamesemery left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 This looks innocuous, though I am not sure I understand how this fixed the problem exactly.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants