Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update htsjdk to 2.18.2 #5585

Merged
merged 1 commit into from
Jan 17, 2019
Merged

Update htsjdk to 2.18.2 #5585

merged 1 commit into from
Jan 17, 2019

Conversation

lbergelson
Copy link
Member

  • Updating htsjdk 2.18.1 -> 2.18.2
  • Remove deprecated method use
  • Changing IntervalUtilsUnitTest due to changes in IntervalList
    • IntervalList now rejects certain invalid intervals that it previously didn't and throw IllegalArgumentException.
    • This ends up changing which exceptions are thrown in some cases, updated some tests to accept both MalformedFile and MalforedGenomeLoc.

* Updating htsjdk 2.18.1 -> 2.18.2
* Remove deprecated method use
* Changing IntervalUtilsUnitTest due to changes in IntervalList
   * IntervalList now rejects certain invalid intervals that it previously didn't and throw IllegalArgumentException.
   * This ends up changing which exceptions are thrown in some cases, updated some tests to accept both MalformedFile and MalforedGenomeLoc.
@codecov-io
Copy link

codecov-io commented Jan 17, 2019

Codecov Report

Merging #5585 into master will increase coverage by 0.006%.
The diff coverage is 100%.

@@              Coverage Diff               @@
##             master     #5585       +/-   ##
==============================================
+ Coverage     87.04%   87.046%   +0.006%     
- Complexity    31490     31492        +2     
==============================================
  Files          1924      1924               
  Lines        145189    145189               
  Branches      16082     16082               
==============================================
+ Hits         126373    126381        +8     
+ Misses        12958     12951        -7     
+ Partials       5858      5857        -1
Impacted Files Coverage Δ Complexity Δ
...titute/hellbender/utils/IntervalUtilsUnitTest.java 91.906% <ø> (ø) 146 <0> (ø) ⬇️
...e/spark/datasources/VariantsSparkSinkUnitTest.java 82.171% <100%> (ø) 28 <0> (ø) ⬇️
...nder/utils/runtime/StreamingProcessController.java 67.773% <0%> (+0.474%) 33% <0%> (ø) ⬇️
...ithwaterman/SmithWatermanIntelAlignerUnitTest.java 90% <0%> (+30%) 2% <0%> (ø) ⬇️
...utils/smithwaterman/SmithWatermanIntelAligner.java 90% <0%> (+40%) 3% <0%> (+2%) ⬆️

Copy link
Collaborator

@droazen droazen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 merge when tests pass

@droazen droazen merged commit b64bb14 into master Jan 17, 2019
@droazen droazen deleted the lb_update_htsjdk_to_2.18.2 branch January 17, 2019 19:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants