fixing overflow in GatkSparkTool.getRecommendedNumReducers() #5586
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #5586 +/- ##
==============================================
+ Coverage 87.04% 87.049% +0.009%
- Complexity 31490 31527 +37
==============================================
Files 1924 1928 +4
Lines 145189 145340 +151
Branches 16082 16089 +7
==============================================
+ Hits 126373 126517 +144
- Misses 12958 12963 +5
- Partials 5858 5860 +2
|
droazen
previously requested changes
Jan 17, 2019
| @@ -365,8 +366,8 @@ public int getRecommendedNumReducers() { | |||
| if (numReducers != 0) { | |||
| return numReducers; | |||
| } | |||
| int size = readInputs.keySet().stream().mapToInt(k -> (int) BucketUtils.dirSize(k)).sum(); | |||
| return 1 + (size / getTargetPartitionSize()); | |||
| long size = readInputs.keySet().stream().mapToLong(k -> BucketUtils.dirSize(k)).sum(); | |||
There was a problem hiding this comment.
Can you add an explicit check for overflow before downcasting the long?
jamesemery
approved these changes
Jan 17, 2019
| int size = readInputs.keySet().stream().mapToInt(k -> (int) BucketUtils.dirSize(k)).sum(); | ||
| return 1 + (size / getTargetPartitionSize()); | ||
| long size = readInputs.keySet().stream().mapToLong(k -> BucketUtils.dirSize(k)).sum(); | ||
| return 1 + Math.toIntExact(size / getTargetPartitionSize()); |
There was a problem hiding this comment.
If you are going to use a throwing method you should at least catch this exception and give a helpful error message, as some user/developer may want to increase the target partition size to compensate or some other such thing.
|
@droazen @jamesemery I've made changes, could someone take a look if you get a chance. |
jamesemery
approved these changes
Jan 22, 2019
lbergelson
dismissed
droazen’s stale review
responded to these comments and James did a re-review
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.