Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

VCF Data Sources now preserve FILTER field #5598

Merged
merged 4 commits into from
Jan 24, 2019

Conversation

jonn-smith
Copy link
Collaborator

No description provided.

Copy link
Contributor

@LeeTL1220 LeeTL1220 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you add a test that will produce a VCF with a funcotation annotation and that we can parse it and retrieve the FILTER field?

* The name of the additional FILTER status field to add to VCF annotations to preserve the FILTER status of the original (data source)
* variant.
*/
private static final String FILTER_FIELD_NAME = "FILTER";
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Isn't there a VCFConstants constant for this?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not that I can see. There's one that's close, but contains comments which won't work:

public static final String FILTER_HEADER_START = "##FILTER";

@codecov-io
Copy link

codecov-io commented Jan 23, 2019

Codecov Report

Merging #5598 into master will increase coverage by 0.001%.
The diff coverage is 95.652%.

@@               Coverage Diff               @@
##              master     #5598       +/-   ##
===============================================
+ Coverage     87.047%   87.048%   +0.001%     
- Complexity     31525     31528        +3     
===============================================
  Files           1928      1928               
  Lines         145343    145377       +34     
  Branches       16090     16091        +1     
===============================================
+ Hits          126517    126548       +31     
- Misses         12966     12967        +1     
- Partials        5860      5862        +2
Impacted Files Coverage Δ Complexity Δ
...dataSources/vcf/VcfFuncotationFactoryUnitTest.java 98.104% <100%> (+0.055%) 30 <1> (+1) ⬆️
...er/tools/funcotator/FuncotatorIntegrationTest.java 85.253% <100%> (+0.372%) 113 <1> (+1) ⬆️
...cotator/dataSources/vcf/VcfFuncotationFactory.java 88.05% <100%> (+0.469%) 48 <0> (ø) ⬇️
...nder/tools/funcotator/FuncotatorTestConstants.java 98.333% <100%> (+0.028%) 1 <0> (ø) ⬇️
...ute/hellbender/utils/test/FuncotatorTestUtils.java 95.161% <66.667%> (-3.084%) 7 <1> (+1)
...nder/utils/runtime/StreamingProcessController.java 67.299% <0%> (-0.474%) 33% <0%> (ø)

@jonn-smith jonn-smith force-pushed the jts_funcotator_vcf_filter_preservation_5592 branch from 99a20d5 to f9fba5b Compare January 23, 2019 22:03
@jonn-smith
Copy link
Collaborator Author

@LeeTL1220 Added in a specific integration test for the FILTER field.

Also rebased on master to fix the unrelated R test failures.

@jonn-smith jonn-smith merged commit b41d8af into master Jan 24, 2019
@jonn-smith jonn-smith deleted the jts_funcotator_vcf_filter_preservation_5592 branch January 24, 2019 04:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants