Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change default blocking and NON-REF LOD params for M2 GVCF mode #5615

Merged
merged 2 commits into from
Jan 29, 2019

Conversation

ldgauthier
Copy link
Contributor

Teeny tiny PR -- not happy with the AF thresholding for GVCF mode yet

@ldgauthier
Copy link
Contributor Author

@droazen I'd like this to squeeze into 4.1. Tests pass locally after the second commit.

@codecov-io
Copy link

codecov-io commented Jan 28, 2019

Codecov Report

Merging #5615 into master will decrease coverage by 0.151%.
The diff coverage is 100%.

@@               Coverage Diff               @@
##              master     #5615       +/-   ##
===============================================
- Coverage     87.037%   86.886%   -0.151%     
- Complexity     31537     31614       +77     
===============================================
  Files           1930      1933        +3     
  Lines         145455    145939      +484     
  Branches       16090     16178       +88     
===============================================
+ Hits          126600    126801      +201     
- Misses         12996     13255      +259     
- Partials        5859      5883       +24
Impacted Files Coverage Δ Complexity Δ
...r/tools/walkers/mutect/Mutect2IntegrationTest.java 91.623% <ø> (ø) 89 <0> (ø) ⬇️
...der/tools/walkers/mutect/M2ArgumentCollection.java 88.889% <100%> (ø) 14 <0> (ø) ⬇️
...ithwaterman/SmithWatermanIntelAlignerUnitTest.java 60% <0%> (-30%) 2% <0%> (ø)
...oadinstitute/hellbender/utils/gcs/BucketUtils.java 64.961% <0%> (-13.271%) 56% <0%> (+17%)
...rg/broadinstitute/hellbender/utils/io/IOUtils.java 59.877% <0%> (-13.105%) 114% <0%> (+19%)
...utils/smithwaterman/SmithWatermanIntelAligner.java 80% <0%> (-10%) 3% <0%> (ø)
...broadinstitute/hellbender/engine/FeatureInput.java 86.869% <0%> (-6.187%) 26% <0%> (+8%)
...institute/hellbender/engine/FeatureDataSource.java 74.556% <0%> (-1.914%) 54% <0%> (+12%)
...lotypecaller/readthreading/ReadThreadingGraph.java 88.608% <0%> (-0.253%) 144% <0%> (-1%)
...notyper/GenotypeCalculationArgumentCollection.java 100% <0%> (ø) 4% <0%> (+2%) ⬆️
... and 5 more

@droazen
Copy link
Collaborator

droazen commented Jan 28, 2019

@davidbenjamin please review

Copy link
Contributor

@davidbenjamin davidbenjamin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You can take or leave the comment about avoiding the initialization block. 👍

@@ -251,12 +251,12 @@ public double getInitialLod() {
"(must be specified in increasing order)", optional = true)
public List<Double> GVCFGQBands = new ArrayList<>(70);
{
for (double i = -4.0; i <= 1; i = i + 0.5) {
for (double i = -2.5; i <= 1; i = i + 0.5) {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you use GVCFGQBands = Arrays.asList(MathUtils.createEvenlySpacedPoints(-2.5, 1, 8))?

@ldgauthier
Copy link
Contributor Author

I'm going to keep the initialization as is because it mirrors HaplotypeCaller and because I feel like defining blocks by their size is more intuitive than defining the number of blocks between two bounds.

@ldgauthier ldgauthier merged commit 7b6de94 into master Jan 29, 2019
@ldgauthier ldgauthier deleted the ldg_changeM2GVCFdefaultswq branch January 29, 2019 21:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants