Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

TableReader and TableWriter take in a Path #5785

Merged
merged 5 commits into from
Mar 19, 2019
Merged

TableReader and TableWriter take in a Path #5785

merged 5 commits into from
Mar 19, 2019

Commits on Mar 12, 2019

  1. TableReader and TableWriter take in a Path 

    All subclasses do the same.

This involves updating all callers to pass a Path instead of a File.

Fixes #5747
    @jean-philippe-martin
    jean-philippe-martin committed Mar 12, 2019
    Configuration menu
    Copy the full SHA
    247a8a4 View commit details
    Browse the repository at this point in the history

  2. Delete dead code, minor style change

    @jean-philippe-martin
    jean-philippe-martin committed Mar 12, 2019
    Configuration menu
    Copy the full SHA
    29333db View commit details
    Browse the repository at this point in the history

  3. Merge new changes 

    Also, update the newly-written code to use Path instead of File.
We're in a race of sorts, it seems.
    @jean-philippe-martin
    jean-philippe-martin committed Mar 12, 2019
    Configuration menu
    Copy the full SHA
    e4f290c View commit details
    Browse the repository at this point in the history

  4. Add NIO test for TableReader 

    A unit test with Jimfs, so it's fast but still checks that we're not converting
the Path to a File along the way.
    @jean-philippe-martin
    jean-philippe-martin committed Mar 12, 2019
    Configuration menu
    Copy the full SHA
    e275927 View commit details
    Browse the repository at this point in the history

Commits on Mar 18, 2019

  1. Apply reviewer feedback

    @jean-philippe-martin
    jean-philippe-martin committed Mar 18, 2019
    Configuration menu
    Copy the full SHA
    02f30b7 View commit details
    Browse the repository at this point in the history