Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move to GenomicsDB 1.0.4 version to get AS_QUALapprox and AS_VarDP fields treated as array of int vectors #5933

Merged
merged 1 commit into from
May 20, 2019

Conversation

nalinigans
Copy link
Contributor

@nalinigans nalinigans commented May 10, 2019

See GenomicsDB/GenomicsDB@10d9ea7 for the relevant changes.

@droazen
Copy link
Collaborator

droazen commented May 10, 2019

@ldgauthier Mind taking this one for a spin?

@codecov
Copy link

codecov bot commented May 10, 2019

Codecov Report

Merging #5933 into master will increase coverage by 0.001%.
The diff coverage is n/a.

@@              Coverage Diff               @@
##             master     #5933       +/-   ##
==============================================
+ Coverage     86.84%   86.841%   +0.001%     
- Complexity    32326     32327        +1     
==============================================
  Files          1991      1991               
  Lines        149342    149342               
  Branches      16482     16482               
==============================================
+ Hits         129689    129690        +1     
  Misses        13646     13646               
+ Partials       6007      6006        -1
Impacted Files Coverage Δ Complexity Δ
...lotypecaller/readthreading/ReadThreadingGraph.java 88.971% <0%> (+0.245%) 159% <0%> (ø) ⬇️

nalinigans referenced this pull request in GenomicsDB/GenomicsDB May 10, 2019
Copy link
Contributor

@ldgauthier ldgauthier left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works perfectly, thanks!

@nalinigans
Copy link
Contributor Author

@droazen, would it be ok to merge this PR? Thanks.

@droazen droazen merged commit d5e2013 into master May 20, 2019
@droazen droazen deleted the nalini_as_fields branch May 20, 2019 17:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants