Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Treat all source files as UTF-8 for java, javadoc, gatkdoc. #5946

Merged
merged 1 commit into from
May 17, 2019

Conversation

cmnbroad
Copy link
Collaborator

@cmnbroad cmnbroad commented May 17, 2019

I tested this using the following sketchy procedure: I temporarily reverted #5936 on this branch, thereby re-introducing non-ASCII characters into the source. That builds without error, as it should. Then I temporarily changed the newly added encoding declarations included this PR in build.gradle from "UTF-8" to "US-ASCII", after which I was able to reproduce exactly the same errors as reported in #5934, for both compile and gatkDoc tasks. So I think these changes achieve the desired result (accept UTF-8 in source).

@codecov
Copy link

codecov bot commented May 17, 2019

Codecov Report

Merging #5946 into master will increase coverage by 0.005%.
The diff coverage is n/a.

@@               Coverage Diff               @@
##              master     #5946       +/-   ##
===============================================
+ Coverage     86.817%   86.823%   +0.005%     
  Complexity     32344     32344               
===============================================
  Files           1993      1993               
  Lines         149460    149460               
  Branches       16502     16502               
===============================================
+ Hits          129757    129765        +8     
+ Misses         13687     13679        -8     
  Partials        6016      6016
Impacted Files Coverage Δ Complexity Δ
...hellbender/utils/pairhmm/VectorLoglessPairHMM.java 86.842% <0%> (+1.316%) 12% <0%> (ø) ⬇️
.../hellbender/utils/python/PythonScriptExecutor.java 66.667% <0%> (+3.333%) 10% <0%> (ø) ⬇️
...oadinstitute/hellbender/utils/pairhmm/PairHMM.java 78.417% <0%> (+3.597%) 24% <0%> (ø) ⬇️

Copy link
Member

@lbergelson lbergelson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 Thank you @cmnbroad.

@lbergelson lbergelson merged commit 1d2a561 into master May 17, 2019
@cmnbroad cmnbroad deleted the cn_utf8 branch June 16, 2020 21:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants