-
Notifications
You must be signed in to change notification settings - Fork 589
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added an option to opt out of the protections to sorting multiple bam inputs #5974
Merged
jamesemery
merged 6 commits into
master
from
je_enableMixedInputTypesForMarkDuplicatesSpark
May 31, 2019
Merged
Changes from all commits
Commits
Show all changes
6 commits
Select commit
Hold shift + click to select a range
174cb31
added an option to opt out of the protections to sorting multiple bam…
jamesemery 61e6e48
responded to comments and added a second option
jamesemery da6fff1
adding louis's changes to the order handling
jamesemery ff5cfa1
typo
jamesemery 79b6337
expanding the unsorted file treatment to apply to the single file inp…
jamesemery 0de40f9
Flipping all of the confusing boolean states that were causing tests …
jamesemery File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -482,4 +482,26 @@ public void testAssertCorrectSortOrderMultipleBams() { | |
args.addInput(new File(TEST_DATA_DIR,"example.chr1.1-1K.unmarkedDups.noDups.bam")); | ||
runCommandLine(args); | ||
} | ||
|
||
@Test | ||
public void testAssertCorrectSortOrderMultipleBamsOverriding() { | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. add a test case for a single unsorted bam, and one that rejects when there's a coordinate sorted bam along side an unsorted bam |
||
final File output = createTempFile("supplementaryReadUnmappedMate", "bam"); | ||
final ArgumentsBuilder args = new ArgumentsBuilder(); | ||
args.addOutput(output); | ||
args.addInput(new File(TEST_DATA_DIR,"optical_dupes.bam")); | ||
args.addInput(new File(TEST_DATA_DIR,"example.chr1.1-1K.unmarkedDups.noDups.bam")); | ||
args.addArgument(MarkDuplicatesSpark.ALLOW_MULTIPLE_SORT_ORDERS_IN_INPUT_ARG); | ||
runCommandLine(args); | ||
} | ||
|
||
@Test | ||
public void testAssertAssumeUnsortedFilesAreQueryGroupedFiles() { | ||
final File output = createTempFile("supplementaryReadUnmappedMate", "bam"); | ||
final ArgumentsBuilder args = new ArgumentsBuilder(); | ||
args.addOutput(output); | ||
args.addInput(new File(TEST_DATA_DIR,"optical_dupes.queryname.bam")); | ||
args.addInput(new File(TEST_DATA_DIR,"optical_dupes.unsorted.querygrouped.sam")); | ||
args.addArgument(MarkDuplicatesSpark.TREAT_UNSORTED_AS_ORDERED); | ||
runCommandLine(args); | ||
} | ||
} |
16 changes: 16 additions & 0 deletions
16
...itute/hellbender/tools/walkers/MarkDuplicatesGATK/optical_dupes.unsorted.querygrouped.sam
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,16 @@ | ||
@HD VN:1.5 SO:unsorted | ||
@SQ SN:chr1 LN:101 | ||
@SQ SN:chr2 LN:101 | ||
@SQ SN:chr3 LN:101 | ||
@SQ SN:chr4 LN:101 | ||
@SQ SN:chr5 LN:101 | ||
@SQ SN:chr6 LN:101 | ||
@SQ SN:chr7 LN:404 | ||
@SQ SN:chr8 LN:202 | ||
@RG ID:1AAXX.1 SM:Hi,Mom! LB:mylib PL:ILLUMINA | ||
@PG ID:MarkDuplicates PN:MarkDuplicates VN:1 CL:MarkDuplicates merge1.sam PP:bwa | ||
@PG ID:bwa PN:bwa VN:1 CL:bwa aln | ||
C4N4WACXX140821:8:1112:2344:1984 83 chr7 1 255 101M = 302 201 CAACAGAAGCNGGNATCTGTGTTTGTGTTTCGGATTTCCTGCTGAANNGNTTNTCGNNTCNNNNNNNNATCCCGATTTCNTTCCGCAGCTNACCTCCCAAN )'.*.+2,))&&'&*/)-&*-)&.-)&)&),/-&&..)./.,.).*&&,&.&&-)&&&0*&&&&&&&&/32/,01460&&/6/*0*/2/283//36868/& PG:Z:MarkDuplicates RG:Z:1AAXX.1 | ||
C4N4WACXX140821:8:1112:2344:1984 163 chr7 302 255 101M = 1 -201 NCGCGGCATCNCGATTTCTTTCCGCAGCTAACCTCCCGACAGATCGGCAGCGCGTCGTGTAGGTTATTATGGTACATCTTGTCGTGCGGCNAGAGCATACA &/15445666651/566666553+2/14/&/555512+3/)-'/-&-'*+))*''13+3)'//++''/'))/3+&*5++)&'2+&+/*&-&&*)&-./1'1 PG:Z:MarkDuplicates RG:Z:1AAXX.1 | ||
C4N4WACXX140821:8:1112:2344:1985 83 chr7 1 255 101M = 302 201 CAACAGAAGCNGGNATCTGTGTTTGTGTTTCGGATTTCCTGCTGAANNGNTTNTCGNNTCNNNNNNNNATCCCGATTTCNTTCCGCAGCTNACCTCCCAAN )'.*.+2,))&&'&*/)-&*-)&.-)&)&),/-&&..)./.,.).*&&,&.&&-)&&&0*&&&&&&&&/32/,01460&&/6/*0*/2/283//36868/& PG:Z:MarkDuplicates RG:Z:1AAXX.1 | ||
C4N4WACXX140821:8:1112:2344:1985 163 chr7 302 255 101M = 1 -201 NCGCGGCATCNCGATTTCTTTCCGCAGCTAACCTCCCGACAGATCGGCAGCGCGTCGTGTAGGTTATTATGGTACATCTTGTCGTGCGGCNAGAGCATACA &/15445666651/566666553+2/14/&/555512+3/)-'/-&-'*+))*''13+3)'//++''/'))/3+&*5++)&'2+&+/*&-&&*)&-./1'1 PG:Z:MarkDuplicates RG:Z:1AAXX.1 |
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
woops, sorry
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
whats worse is that I actually caught this yesterday but forgot to push the branch until today... sigh...