Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove Beta label from some Spark tools #5991

Merged
merged 2 commits into from
Jul 29, 2019
Merged

Conversation

tomwhite
Copy link
Contributor

Now that Disq runs tests on 'large' BAM and VCF files (disq-bio/disq#103), we can remove the Beta label from some more of the Spark tools.

@tomwhite tomwhite requested a review from droazen June 10, 2019 11:08
@codecov
Copy link

codecov bot commented Jun 10, 2019

Codecov Report

Merging #5991 into master will increase coverage by 0.001%.
The diff coverage is n/a.

@@               Coverage Diff               @@
##              master     #5991       +/-   ##
===============================================
+ Coverage     86.926%   86.927%   +0.001%     
+ Complexity     32732     32731        -1     
===============================================
  Files           2014      2014               
  Lines         151333    151333               
  Branches       16612     16612               
===============================================
+ Hits          131548    131549        +1     
  Misses         13724     13724               
+ Partials        6061      6060        -1
Impacted Files Coverage Δ Complexity Δ
...lbender/tools/spark/pipelines/CountReadsSpark.java 90.909% <ø> (ø) 5 <0> (ø) ⬇️
...ellbender/tools/spark/pipelines/FlagStatSpark.java 90% <ø> (ø) 4 <0> (ø) ⬇️
...lbender/tools/spark/pipelines/CountBasesSpark.java 90% <ø> (ø) 5 <0> (ø) ⬇️
...nder/tools/spark/pipelines/PrintVariantsSpark.java 66.667% <ø> (ø) 2 <0> (ø) ⬇️
...nder/tools/spark/pipelines/CountVariantsSpark.java 90.909% <ø> (ø) 4 <0> (ø) ⬇️
...lbender/tools/spark/pipelines/PrintReadsSpark.java 100% <ø> (ø) 3 <0> (ø) ⬇️
...lotypecaller/readthreading/ReadThreadingGraph.java 88.971% <0%> (+0.245%) 159% <0%> (ø) ⬇️

@tomwhite
Copy link
Contributor Author

@droazen I checked and PrintReadsSparkIntegrationTest and PrintVariantsSparkIntegrationTest both test GCS inputs and outputs, so it should be OK to take PrintReadsSpark and PrintVariantsSpark out of beta too.

@droazen droazen requested a review from jamesemery July 15, 2019 15:25
@droazen droazen removed their request for review July 15, 2019 15:25
Copy link
Collaborator

@jamesemery jamesemery left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

After some discussion we have decided that removing beta tags from these tools is certainly no more dangerous than it was for MarkDuplicatesSpark, especially given recent fixes in Disq we can be at least a little more confident that spark can handle at least some of our regular use cases.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants