testing if removing codecov upload removes the check #6052
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
this seemed to work |
droazen
requested changes
Jul 23, 2019
| @@ -186,7 +186,6 @@ script: | |||
| fi; | |||
|
|
|||
| after_success: | |||
| - bash <(curl -s https://codecov.io/bash) | |||
There was a problem hiding this comment.
Recommend commenting this out (with a brief explanation of why it's disabled) rather than deleting it outright.
| @@ -1,5 +1,4 @@ | |||
| [](https://travis-ci.com/broadinstitute/gatk) | |||
| [](https://codecov.io/gh/broadinstitute/gatk) | |||
There was a problem hiding this comment.
Comment out instead of deleting
There was a problem hiding this comment.
not sure how to comment something out of the readme in a sane way.
lbergelson
force-pushed
the
lb_test_remove_codecov
branch
from
77a76ae
to
a77318c
Compare
droazen
approved these changes
Jul 24, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
testing if removing the codecov upload line in our yml disables the reporting on the pr