Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding NIO and updating to WDL 1.0 to MT pipeline #6074

Merged
merged 3 commits into from
Aug 6, 2019
Merged

Conversation

meganshand
Copy link
Contributor

Adds NIO to the SubsetBam task and converts all the MT pipeline WDLs to WDL 1.0. I ran this on one sample in Terra and it worked.

Copy link
Contributor

@ldgauthier ldgauthier left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Were there any Mutect2 updates that need to go in or are the versions all up-to-date?

File input_bam
String basename = basename(input_bam, ".bam")
input {
File input_bam
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If we call RevertSam through GATK we can use NIO here too, right?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That's true, but by the time we subset down to just the mt bam everything is pretty quick. The NIO above helps because it's still on the full size hg38 wgs bam.

@meganshand meganshand removed the request for review from maddyduran August 5, 2019 13:38
@meganshand
Copy link
Contributor Author

Thanks for the review @ldgauthier! Mutect should be up to date (or at least as up to date as we've ever run on our truth sets). I'm going to rebase and hope that tests will pass 🤞

@meganshand meganshand merged commit 06df7e8 into master Aug 6, 2019
@meganshand meganshand deleted the ms_mt_wdl branch August 6, 2019 14:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants