Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Logging exceptions during deletion instead of throwing #6125

Merged
merged 2 commits into from
Aug 29, 2019
Merged

Logging exceptions during deletion instead of throwing #6125

merged 2 commits into from
Aug 29, 2019

Conversation

lbergelson
Copy link
Member

  • When running recursive deletion file hooks we now catch all exceptions and log them at DEBUG level instead of letting them propagate.
  • This should reduce confusion when test have deletion failures.

@lbergelson
Logging exceptions during deletion instead of throwing
316c619 
* When running recursive deletion file hooks we now catch all exceptions and log them at DEBUG level instead of letting them propagate.
* This should reduce confusion when test have deletion failures.
droazen
droazen approved these changes Aug 28, 2019
View reviewed changes
Copy link
Collaborator

@droazen droazen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One requested change, otherwise looks good

src/main/java/org/broadinstitute/hellbender/utils/io/DeleteRecursivelyOnExitPathHook.java Outdated
@@ -14,6 +15,7 @@
* This class should be considered an implementation detail of {@link IOUtils#deleteOnExit(Path)} and not used directly.
*/
class DeleteRecursivelyOnExitPathHook {
private static Logger LOG = LogManager.getLogger(DeleteRecursivelyOnExitPathHook.class);
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

final

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

woops

@lbergelson lbergelson merged commit e684080 into master Aug 29, 2019
@lbergelson lbergelson deleted the lb_stop_deletion_error_message_on_shutdown branch August 29, 2019 15:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@droazen droazen droazen approved these changes

Assignees

@lbergelson lbergelson

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@lbergelson @droazen