Rotating travis secrets part 1 and 2 #7521
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
droazen
requested changes
Oct 26, 2021
| @@ -3,7 +3,7 @@ | |||
| # This is expected to be run from the travis root directory. | |||
|
|
|||
| export BOTO_CONFIG=/dev/null; # see for more information https://github.com/broadinstitute/gatk/pull/3350 | |||
| openssl aes-256-cbc -K $encrypted_703d76169d63_key -iv $encrypted_703d76169d63_iv -in resources_for_CI/servicekey.json.enc -out servicekey.json -d; | |||
| openssl aes-256-cbc -K $encrypted_c51214b7dd65_key -iv $encrypted_c51214b7dd65_iv -in resources_for_CI/servicekey.json.enc -out servicekey.json -d | |||
There was a problem hiding this comment.
Is the semicolon at the end of this line really no longer needed?
There was a problem hiding this comment.
That's a good question...
There was a problem hiding this comment.
I don't know but it seems like it should be... hopefully adding it doesn't break everything.
droazen
approved these changes
Oct 26, 2021
Closed
lbergelson
changed the title
* Switch travis variable name from DOCKER_SERVICE_PASS -> DOCKER_SERVICE_TOKEN for clarity * Replace gcloud encrypted key
* Adding a new deploy key for travis to use when authenticating to github * The previous one was deactivated somehow already
lbergelson
force-pushed
the
lb_revoking_keys
branch
from
ac06d08
to
9dceb65
Compare
|
@droazen any new typos here? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This replaces a secret that requires a pr to fix, and updates the name of one of the others.
Requires 1 more step after this.