Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Docker build only lfs pulls main/src/resources/large #7727

Merged
merged 1 commit into from
Mar 17, 2022
Merged

Docker build only lfs pulls main/src/resources/large #7727

merged 1 commit into from
Mar 17, 2022

Conversation

lbergelson
Copy link
Member

  • previously the docker build would unnecessarily pull the test files

@lbergelson
Docker build only lfs pulls main/src/resources/large
a216ab4 
* previously the docker build would unecessarily pull the test files
* testing this to see if it broke things
@lbergelson
Copy link
Member Author

@jamesemery Can you take a quick look at this when you get a chance? It speeds up docker builds and might somewhat reduce test times.

jamesemery
jamesemery approved these changes Mar 16, 2022
View reviewed changes
Copy link
Collaborator

@jamesemery jamesemery left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

god help us when it turns out that building locally and from the docker are inequivalent some time in the future because something in a different lfs folder is missing sometimes...

@lbergelson
Copy link
Member Author

The gradle build actually runs git-lfs if it needs to.

@lbergelson lbergelson merged commit e43dbac into master Mar 17, 2022
@lbergelson lbergelson deleted the lb_only_lfs_main branch March 17, 2022 15:40
mcovarr pushed a commit that referenced this pull request Apr 25, 2022
@lbergelson @mcovarr
Docker build only lfs pulls main/src/resources/large (#7727)
0322dbb 
* Docker build now only downloads the main large resources from git-lfs.  Previously it pulled everything.
* This should make building the docker substantially faster locally and possibly speed up the test suite slightly.
@mcovarr mcovarr mentioned this pull request Apr 25, 2022
Closed
mcovarr pushed a commit that referenced this pull request Apr 25, 2022
@lbergelson @mcovarr
Docker build only lfs pulls main/src/resources/large (#7727)
dfc239d 
* Docker build now only downloads the main large resources from git-lfs.  Previously it pulled everything.
* This should make building the docker substantially faster locally and possibly speed up the test suite slightly.
This was referenced Mar 17, 2023
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jamesemery jamesemery jamesemery approved these changes

Assignees

@jamesemery jamesemery

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@lbergelson @jamesemery