Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mutect3 dataset enhancements: optional truth VCF for labels, seq error likelihood annotation #7975

Merged
merged 2 commits into from
Aug 5, 2022

Conversation

davidbenjamin
Copy link
Contributor

No description provided.

@davidbenjamin davidbenjamin force-pushed the db_mutect3_stuff branch 2 times, most recently from 6ce60b7 to d85d164 Compare August 4, 2022 22:08
@davidbenjamin
Copy link
Contributor Author

@meganshand Would you mind reviewing this PR, which will enable M3 testing on Ultima? To the extent your conscience permits it really only needs a rubber stamp. No one besides me is familiar with the M3 code and while that is eventually worth addressing I don't think you or anyone else should be responsible for increasing the M3 bus factor until it is more stable.

@codecov
Copy link

codecov bot commented Aug 4, 2022

Codecov Report

Merging #7975 (9fd8de7) into master (8d81423) will decrease coverage by 0.001%.
The diff coverage is 63.636%.

@@               Coverage Diff               @@
##              master     #7975       +/-   ##
===============================================
- Coverage     86.679%   86.679%   -0.001%     
  Complexity     38455     38455               
===============================================
  Files           2310      2310               
  Lines         180387    180401       +14     
  Branches       19845     19848        +3     
===============================================
+ Hits          156358    156369       +11     
- Misses         17087     17088        +1     
- Partials        6942      6944        +2     
Impacted Files Coverage Δ
...der/tools/walkers/mutect/M2ArgumentCollection.java 95.000% <ø> (ø)
...der/tools/walkers/mutect/Mutect3DatasetEngine.java 87.786% <63.158%> (-2.130%) ⬇️
.../tools/walkers/mutect/SomaticGenotypingEngine.java 93.617% <66.667%> (-0.469%) ⬇️
.../hellbender/utils/python/PythonUnitTestRunner.java 78.689% <0.000%> (+3.279%) ⬆️

@meganshand meganshand self-assigned this Aug 5, 2022
Copy link
Contributor

@meganshand meganshand left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @davidbenjamin! Looks good 👍

@davidbenjamin
Copy link
Contributor Author

Thanks @meganshand!

@davidbenjamin davidbenjamin merged commit e1cc573 into master Aug 5, 2022
@davidbenjamin davidbenjamin deleted the db_mutect3_stuff branch August 5, 2022 20:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants