Fixed Funcotator VCF output renderer to keep B37 contig names in the VCF output file #8539
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jonn-smith
reviewed
Oct 4, 2023
src/main/java/org/broadinstitute/hellbender/tools/funcotator/FuncotatorEngine.java
Show resolved
Hide resolved
droazen
requested changes
Oct 4, 2023
There was a problem hiding this comment.
@jamesemery Looks reasonable, but I'm not sure we have adequate test coverage on the new code
src/main/java/org/broadinstitute/hellbender/tools/funcotator/Funcotator.java
Outdated
Show resolved
Hide resolved
src/main/java/org/broadinstitute/hellbender/tools/funcotator/FuncotatorEngine.java
Show resolved
Hide resolved
|
@droazen back to you |
droazen
requested changes
Oct 5, 2023
| @@ -924,7 +923,10 @@ protected void enqueueAndHandleVariant(final VariantContext variant, final Refer | |||
|
|
|||
| final FuncotationMap funcotationMap = funcotatorEngine.createFuncotationMapForVariant(variant, referenceContext, featureContext); | |||
|
|
|||
| // This is necessary because we want to revert the variant contig name change if it was applied in the FuncotatorEngine::getCorrectVariantContextForReference method before outputting the vcf. | |||
There was a problem hiding this comment.
This comment is still misleading -- can you make it clear that we don't always want to revert the variant contig name change, only in the very specific case where the input is b37 and the reference is hg19?
droazen
approved these changes
Oct 5, 2023
jamesemery
force-pushed
the
je_fixB37HG19ChrMismatchFuncotator
branch
from
6ab2a84
to
78eddbc
Compare
rickymagner
pushed a commit
that referenced
this pull request
Nov 28, 2023
… names on output for B37 aligned files (#8539)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes a longstanding issue that resulted in mismatching sequence dictionary/vcf lines for B37 data provided to funcotator.