-
Notifications
You must be signed in to change notification settings - Fork 589
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Ultima, New/Updated Features #8579
Merged
meganshand
merged 23 commits into
broadinstitute:master
from
Ultimagen:ultima.new-features.rebase
Nov 28, 2023
Merged
Ultima, New/Updated Features #8579
meganshand
merged 23 commits into
broadinstitute:master
from
Ultimagen:ultima.new-features.rebase
Nov 28, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
the number of reads in the locus that pass the FeatureMap filters, regardless of whether the considered base matches the reference or not
format <name>[,<type>[,<desc>]]. types: Integer, Float, String, Character, Fl Defaults to type String Defaults to desc: copy-attr: <name>
added deviation to reports report to use true base instead of aligned Fixed hardcoded 12-mer (partial fix) --add-mean-call parameter added ReadProbs and ReadMeanCall added merge changes
- range extended - clipping implemented
Adding option to omit lines with zero count from report. Note that some initial lines w/ 0 are kept to make sure a table will be output even if empty. Also better handling of unmapped reads.
meganshand
reviewed
Nov 27, 2023
src/main/java/org/broadinstitute/hellbender/tools/walkers/featuremapping/FlowFeatureMapper.java
Outdated
Show resolved
Hide resolved
src/main/java/org/broadinstitute/hellbender/tools/walkers/featuremapping/FlowFeatureMapper.java
Outdated
Show resolved
Hide resolved
src/main/java/org/broadinstitute/hellbender/tools/walkers/featuremapping/FlowFeatureMapper.java
Outdated
Show resolved
Hide resolved
src/main/java/org/broadinstitute/hellbender/tools/walkers/featuremapping/SNVMapper.java
Outdated
Show resolved
Hide resolved
src/main/java/org/broadinstitute/hellbender/tools/walkers/groundtruth/GroundTruthScorer.java
Outdated
Show resolved
Hide resolved
src/main/java/org/broadinstitute/hellbender/tools/walkers/groundtruth/GroundTruthScorer.java
Outdated
Show resolved
Hide resolved
src/main/java/org/broadinstitute/hellbender/tools/walkers/groundtruth/GroundTruthScorer.java
Show resolved
Hide resolved
@meganshand: I've addressed your comments. Thank you |
meganshand
approved these changes
Nov 28, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, thanks!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New: GroundTruthScorer
Update: FlowFeatureMapper