-
Notifications
You must be signed in to change notification settings - Fork 29
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Generic liftover #190
Comments
Something like this may be generally useful:
Also, something else to consider:
|
Related to #162 |
Finally opened a PR for this: #246 |
Now that #246 is merged, is this issue resolved? |
Yup! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Right now much of the code in utils.liftover is specific (or has specific options) for gnomad; specific parts should be moved to
gnomad_qc.v2
and all there should be generic.I also think that checkpointing should be taken out of e.g.
lift_data
since it may not be desirable in all situations (e.g very small table)Finally, docstring needs work, e.g.
:param rg: Reference genome
--> is this the old or new reference?The text was updated successfully, but these errors were encountered: