Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated liftover functions to be more generic #246

Merged
merged 5 commits into from
Aug 14, 2020
Merged

Updated liftover functions to be more generic #246

merged 5 commits into from
Aug 14, 2020

Conversation

ch-kr
Copy link
Contributor

@ch-kr ch-kr commented Aug 4, 2020

...also removed now redundant functions

@ch-kr ch-kr requested a review from lfrancioli August 4, 2020 19:16
@ch-kr ch-kr mentioned this pull request Aug 4, 2020
@ch-kr ch-kr requested a review from mike-w-wilson August 5, 2020 14:28
Copy link
Contributor

@mike-w-wilson mike-w-wilson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks great! It is super clean. I had a couple questions and a few style things but otherwise 👍

gnomad/utils/liftover.py Show resolved Hide resolved
gnomad/utils/liftover.py Show resolved Hide resolved
gnomad/utils/liftover.py Show resolved Hide resolved
gnomad/utils/liftover.py Show resolved Hide resolved
gnomad/utils/liftover.py Show resolved Hide resolved
gnomad/utils/liftover.py Show resolved Hide resolved
gnomad/utils/liftover.py Outdated Show resolved Hide resolved
gnomad/utils/liftover.py Outdated Show resolved Hide resolved
gnomad/utils/liftover.py Outdated Show resolved Hide resolved
@ch-kr ch-kr merged commit 28b2e6a into master Aug 14, 2020
@ch-kr ch-kr deleted the liftover branch August 14, 2020 12:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants