Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Liftover includes hard-coded path to private bucket #225

Closed
nawatts opened this issue May 14, 2020 · 1 comment
Closed

Liftover includes hard-coded path to private bucket #225

nawatts opened this issue May 14, 2020 · 1 comment

Comments

@nawatts
Copy link
Contributor

nawatts commented May 14, 2020

if gnomad:
return f"gs://gnomad/liftover/release/2.1.1/ht/{data_type}/gnomad.{data_type}.r2.1.1.liftover.ht"

It's surprising that setting gnomad=True sets this path to a specific bucket. Others without access to this bucket may run this script on public gnomAD data.

@nawatts
Copy link
Contributor Author

nawatts commented Aug 17, 2020

Resolve by #246.

@nawatts nawatts closed this as completed Aug 17, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant