Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix default_lift_data #270

Merged
merged 2 commits into from
Nov 16, 2020
Merged

Conversation

mkanai
Copy link
Contributor

@mkanai mkanai commented Nov 2, 2020

The current default_lift_data doesn't work since new_locus is set as new_locus=lifted_over_locus.result in liftover_expr as below. This PR fixes this error.

return hl.struct(
new_locus=lifted_over_locus.result,
new_alleles=lifted_over_alleles,
original_locus=locus,
original_alleles=alleles,
locus_fail_liftover=hl.is_missing(lifted_over_locus),
ref_allele_mismatch=lifted_over_locus.result.sequence_context()
!= lifted_over_alleles[0],
)

Copy link
Contributor

@ch-kr ch-kr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks for catching this! LGTM.

I have two small comments -- could you reformat with black and add an entry to the changelog noting the fix?

@ch-kr
Copy link
Contributor

ch-kr commented Nov 2, 2020

ah sorry just saw this #269

@mkanai
Copy link
Contributor Author

mkanai commented Nov 2, 2020

Thanks Katherine! I added the changelog.

@nawatts
Copy link
Contributor

nawatts commented Nov 16, 2020

Hi @mkanai. The master branch has been repaired. If you update your branch, Pylint and documentation checks should run now.

@mkanai mkanai force-pushed the fix_default_lift_data branch from 4a4efc6 to f0c13a8 Compare November 16, 2020 16:06
@mkanai
Copy link
Contributor Author

mkanai commented Nov 16, 2020

@nawatts thanks! I updated and it seems all checks have passed.

@ch-kr ch-kr merged commit 64120c0 into broadinstitute:master Nov 16, 2020
@mkanai mkanai deleted the fix_default_lift_data branch November 16, 2020 16:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants