Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Updated rep_on_read to also work on HTs #283

Merged
merged 7 commits into from
Jan 21, 2021
Merged

Updated rep_on_read to also work on HTs #283

merged 7 commits into from
Jan 21, 2021

Conversation

ch-kr
Copy link
Contributor

@ch-kr ch-kr commented Jan 15, 2021

This code updates rep_on_read but won't work right away (_calculate_new_partitions isn't exposed on Tables yet)

@ch-kr ch-kr requested a review from tpoterba January 15, 2021 14:30
@tpoterba
Copy link
Contributor

looks good to me. However, I've actually added a _n_partitions arg to read_table/read_matrix_table in this PR so this can be simplified further!

@ch-kr ch-kr requested a review from jkgoodrich January 21, 2021 16:02
jkgoodrich
jkgoodrich approved these changes Jan 21, 2021
View reviewed changes
Copy link
Contributor

@jkgoodrich jkgoodrich left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a small change to the change log

CHANGELOG.md Outdated Show resolved Hide resolved
@ch-kr ch-kr merged commit d893882 into master Jan 21, 2021
@ch-kr ch-kr deleted the rep_on_read branch January 21, 2021 21:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jkgoodrich jkgoodrich jkgoodrich approved these changes

@tpoterba tpoterba Awaiting requested review from tpoterba

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ch-kr @tpoterba @jkgoodrich