Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add n_partitions option to get_qc_mt before LD pruning #472

Merged
merged 8 commits into from
Aug 16, 2022
Merged

Add n_partitions option to get_qc_mt before LD pruning #472

merged 8 commits into from
Aug 16, 2022

Conversation

klaricch
Copy link
Contributor

These edits add a 'partitions' parameter to the get_qc_mt function so that MTs can be repartitioned before the LD pruning step

@klaricch klaricch requested a review from jkgoodrich August 15, 2022 19:51
jkgoodrich
jkgoodrich reviewed Aug 16, 2022
View reviewed changes
Copy link
Contributor

@jkgoodrich jkgoodrich left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a couple small things. Also maybe change the description to "Add n_partitions option to get_qc_mt before LD pruning" Just because the title will be used for the change log

gnomad/sample_qc/pipeline.py Outdated Show resolved Hide resolved
gnomad/sample_qc/pipeline.py Outdated Show resolved Hide resolved
gnomad/sample_qc/pipeline.py Outdated Show resolved Hide resolved
gnomad/sample_qc/pipeline.py Outdated Show resolved Hide resolved
@klaricch klaricch changed the title add repartition option before ld prune Add n_partitions option to get_qc_mt before LD pruning Aug 16, 2022
klaricch and others added 3 commits August 16, 2022 12:26
@klaricch @jkgoodrich
Update gnomad/sample_qc/pipeline.py
e193f10 
Co-authored-by: jkgoodrich <33063077+jkgoodrich@users.noreply.github.com>
@klaricch @jkgoodrich
Update gnomad/sample_qc/pipeline.py
8a7ac95 
Co-authored-by: jkgoodrich <33063077+jkgoodrich@users.noreply.github.com>
@klaricch
partitions to n_partitions
25be3c6
@klaricch klaricch requested a review from jkgoodrich August 16, 2022 16:31
jkgoodrich
jkgoodrich approved these changes Aug 16, 2022
View reviewed changes
Copy link
Contributor

@jkgoodrich jkgoodrich left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@klaricch klaricch requested a review from jkgoodrich August 16, 2022 17:41
@klaricch klaricch merged commit 0d860a2 into main Aug 16, 2022
@klaricch klaricch deleted the edits_for_subpops branch August 16, 2022 17:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jkgoodrich jkgoodrich jkgoodrich approved these changes

Assignees

@jkgoodrich jkgoodrich

Labels
Changelog: new feature
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@klaricch @jkgoodrich