Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add generic constraint function annotate_constraint_groupings() #497

Merged
merged 24 commits into from
Dec 5, 2022
Merged

Add generic constraint function annotate_constraint_groupings() #497

merged 24 commits into from
Dec 5, 2022

Conversation

averywpx
Copy link
Contributor

No description provided.

@averywpx averywpx requested a review from jkgoodrich October 27, 2022 16:47
@averywpx averywpx self-assigned this Oct 27, 2022
@jkgoodrich jkgoodrich self-assigned this Nov 3, 2022
jkgoodrich
jkgoodrich requested changes Nov 4, 2022
View reviewed changes
Copy link
Contributor

@jkgoodrich jkgoodrich left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some small changes, and a thought on possible restructuring to make it a bit more generalized

gnomad/utils/constraint.py Outdated Show resolved Hide resolved
gnomad/utils/constraint.py Outdated Show resolved Hide resolved
gnomad/utils/constraint.py Outdated Show resolved Hide resolved
gnomad/utils/constraint.py Outdated Show resolved Hide resolved
gnomad/utils/constraint.py Outdated Show resolved Hide resolved
gnomad/utils/constraint.py Outdated Show resolved Hide resolved
gnomad/utils/constraint.py Outdated Show resolved Hide resolved
gnomad/utils/constraint.py Outdated Show resolved Hide resolved
gnomad/utils/constraint.py Outdated Show resolved Hide resolved
gnomad/utils/constraint.py Outdated Show resolved Hide resolved
@averywpx averywpx requested a review from jkgoodrich November 10, 2022 17:38
jkgoodrich
jkgoodrich requested changes Nov 29, 2022
View reviewed changes
Copy link
Contributor

@jkgoodrich jkgoodrich left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good, just some minor changes

gnomad/utils/constraint.py Outdated Show resolved Hide resolved
gnomad/utils/constraint.py Outdated Show resolved Hide resolved
gnomad/utils/constraint.py Outdated Show resolved Hide resolved
gnomad/utils/constraint.py Outdated Show resolved Hide resolved
gnomad/utils/constraint.py Outdated Show resolved Hide resolved
gnomad/utils/constraint.py Outdated Show resolved Hide resolved
gnomad/utils/constraint.py Outdated Show resolved Hide resolved
gnomad/utils/constraint.py Outdated Show resolved Hide resolved
gnomad/utils/constraint.py Outdated Show resolved Hide resolved
gnomad/utils/constraint.py Show resolved Hide resolved
averywpx and others added 3 commits December 1, 2022 04:18
@averywpx @jkgoodrich
Apply suggestions from code review
6aa02c8 
Co-authored-by: jkgoodrich <33063077+jkgoodrich@users.noreply.github.com>
fix change requests
b400c8e
small fix
e5560c4
@averywpx averywpx requested a review from jkgoodrich December 1, 2022 16:15
jkgoodrich
jkgoodrich requested changes Dec 1, 2022
View reviewed changes
Copy link
Contributor

@jkgoodrich jkgoodrich left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A couple small docstring changes. You also need to run Black and fix the failing docstring test.

gnomad/utils/constraint.py Outdated Show resolved Hide resolved
gnomad/utils/constraint.py Outdated Show resolved Hide resolved
gnomad/utils/constraint.py Outdated Show resolved Hide resolved
gnomad/utils/constraint.py Outdated Show resolved Hide resolved
gnomad/utils/constraint.py Outdated Show resolved Hide resolved
gnomad/utils/constraint.py Outdated Show resolved Hide resolved
averywpx and others added 3 commits December 4, 2022 15:12
@averywpx @jkgoodrich
Apply suggestions from code review
ca9301d 
Co-authored-by: jkgoodrich <33063077+jkgoodrich@users.noreply.github.com>
pass check
e251446
to pass checks
0dbd6b8
jkgoodrich
jkgoodrich approved these changes Dec 5, 2022
View reviewed changes
Copy link
Contributor

@jkgoodrich jkgoodrich left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@jkgoodrich jkgoodrich merged commit 5953a6c into main Dec 5, 2022
@jkgoodrich jkgoodrich deleted the constraint_apply_models branch December 5, 2022 15:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jkgoodrich jkgoodrich jkgoodrich approved these changes

Assignees

@jkgoodrich jkgoodrich

@averywpx averywpx

Labels
Changelog: new feature
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@averywpx @jkgoodrich