Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Modifying assign_population_pcs to be more flexible by accepting an array expression in 'pc_cols' and adding a 'pc_expr' parameter instead of always using 'scores' #500

Merged
merged 3 commits into from
Oct 31, 2022

Conversation

jkgoodrich
Copy link
Contributor

@jkgoodrich jkgoodrich commented Oct 27, 2022

Adding this in to be more flexible and work with the example used in the blog post again.

Copy link
Contributor

@mike-w-wilson mike-w-wilson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. A few formatting suggestions(periods) that I based off of other sections. I'm not certain they are necessary though.

gnomad/sample_qc/ancestry.py Outdated Show resolved Hide resolved
gnomad/sample_qc/ancestry.py Outdated Show resolved Hide resolved
gnomad/sample_qc/ancestry.py Outdated Show resolved Hide resolved
Co-authored-by: Mike Wilson <mwilson@broadinstitute.org>
@jkgoodrich jkgoodrich merged commit 62d7bf9 into main Oct 31, 2022
@jkgoodrich jkgoodrich deleted the jg/make_ancestry_pop_assignment_more_flex branch October 31, 2022 18:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants