Modifications to annotate_freq to improve memory use
#577
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gnomad/utils/annotations.py
Outdated
| freq_expr = freq_expr.map( | ||
| lambda cs: cs.annotate( | ||
| AC=cs.AC[1], | ||
| # TODO: This is NA in case AC and AN are 0 -- should we set it to 0? |
There was a problem hiding this comment.
Should we address this here? This TODO has been in here for a while. We could ask in a channel what the preference is for the HT. The browser displays 0 when AN is 0.
There was a problem hiding this comment.
Sure, can you initiate the conversation?
Co-authored-by: Mike Wilson <mwilson@broadinstitute.org>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.