-
Notifications
You must be signed in to change notification settings - Fork 29
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add GTEx import resources #646
Conversation
default_version="v7", | ||
versions={ | ||
"v7": GnomadPublicTableResource( | ||
path="gs://gnomad-public-requester-pays/resources/grch38/gtex_rsem/gtex_rsem_v7.mt", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
path="gs://gnomad-public-requester-pays/resources/grch38/gtex_rsem/gtex_rsem_v7.mt", | |
path="gs://gnomad-public-requester-pays/resources/grch37/gtex/gtex_rsem_v7.mt", |
.replace("\\(", "_") | ||
.replace("\\)", "") | ||
) | ||
mt = mt.key_rows_by() |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Would it work to just not use row_key="transcript_id"
when importing?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
When it's key, I can't remove the version number using annotate
.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah, but I think without row_key="transcript_id"
in the import it won't already be keyed
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You're right, I had row_key in my test code.
I also add a resource for CDS intervals, I was digging into Beryl's "CDS" bed (located here as of now: gs://gnomad-public/papers/2019-tx-annotation/data/other_data/gencode.v19.CDS.Hail.021519.bed) and found it's not accurate for the following reasons:
|
.replace("\\(", "_") | ||
.replace("\\)", "") | ||
) | ||
mt = mt.key_rows_by() |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah, but I think without row_key="transcript_id"
in the import it won't already be keyed
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I just have one comment and then this is good to go. I think I would like to wait on adding the gencode filter function to a PR where it is needed so I can see it used
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
This is to add an automated import function for GTEx data to gnomAD resources. Instead of using manually reheadered file, I downloaded the original expression and sample metadata to get the tissue information, while keeping the original GTEx Sample ID.
The only thing is that where we put these original files for importing?