Add v4 to genome release constants #671
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Add "v4.0" to GENOME_RELEASES and set CURRENT_GENOME_RELEASE to "v4.0" Currently public_release("genomes").versions['4.0'] will fail with a key error. I think the only line this would break is https://github.com/broadinstitute/gnomad_qc/blob/901f0d8629eb69197548c3ae94ccae441bd46a4f/gnomad_qc/v3/annotations/compare_freq.py#L29 but since we are no longer updating v3 we might be able to hard code the version in that script instead |
mike-w-wilson
approved these changes
Jan 25, 2024
There was a problem hiding this comment.
LGTM! I agree we should just hardcode "3.1.2" here: https://github.com/broadinstitute/gnomad_qc/blob/901f0d8629eb69197548c3ae94ccae441bd46a4f/gnomad_qc/v3/annotations/compare_freq.py#L67C19-L67C37.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.