Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Multiome keeper cell metrics #1303

Merged
merged 14 commits into from
Jul 1, 2024
Merged

Multiome keeper cell metrics #1303

merged 14 commits into from
Jul 1, 2024

Conversation

ekiernan
Copy link
Contributor

@ekiernan ekiernan commented Jun 25, 2024 •
edited
Loading

Description

This PR adds library-level keeper cell metrics to the Multiome and Optimus workflows. It is related to this ticket: https://broadworkbench.atlassian.net/jira/software/projects/PD/boards/167?selectedIssue=PD-2653

@github-actions GitHub Actions
Copy link

Remember to squash merge!

@github-actions GitHub Actions
Copy link

🔍Changelog Validation Results:

Comparing changelogs for pipelines that differ from the versions on 'origin/develop':
Optimus.changelog.md has not been changed and needs to be updated
MultiSampleSmartSeq2SingleNucleus.changelog.md has not been changed and needs to be updated
SlideSeq.changelog.md has not been changed and needs to be updated
PairedTag.changelog.md has not been changed and needs to be updated
Multiome.changelog.md has not been changed and needs to be updated
Some changelog files need updating. See output for details.
validation_failed

@github-actions GitHub Actions
Copy link

🔍Version Validation Results:

Comparing versions and changelogs for pipelines that differ from the versions on 'origin/staging':
Optimus.wdl has not been changed and needs updating
MultiSampleSmartSeq2SingleNucleus.wdl has not been changed and needs updating
SlideSeq.wdl has not been changed and needs updating
PairedTag.wdl has not been changed and needs updating
Multiome.wdl has not been changed and needs updating
Some WDLs or changelog files need updating. See output for details.
validation_failed

@ekiernan
Copy link
Contributor Author

retest this please

@github-actions GitHub Actions
Copy link

Remember to squash merge!

@github-actions GitHub Actions
Copy link

🔍Changelog Validation Results:

Comparing changelogs for pipelines that differ from the versions on 'origin/develop':
Optimus.changelog.md has not been changed and needs to be updated
MultiSampleSmartSeq2SingleNucleus.changelog.md has not been changed and needs to be updated
SlideSeq.changelog.md has not been changed and needs to be updated
PairedTag.changelog.md has not been changed and needs to be updated
Multiome.changelog.md has not been changed and needs to be updated
Some changelog files need updating. See output for details.
validation_failed

@github-actions GitHub Actions
Copy link

🔍Version Validation Results:

Comparing versions and changelogs for pipelines that differ from the versions on 'origin/staging':
Optimus.wdl has not been changed and needs updating
MultiSampleSmartSeq2SingleNucleus.wdl has not been changed and needs updating
SlideSeq.wdl has not been changed and needs updating
PairedTag.wdl has not been changed and needs updating
Multiome.wdl has not been changed and needs updating
Some WDLs or changelog files need updating. See output for details.
validation_failed

@ekiernan ekiernan closed this Jun 28, 2024
@ekiernan ekiernan reopened this Jun 28, 2024
@github-actions GitHub Actions
Copy link

Remember to squash merge!

1 similar comment
@github-actions GitHub Actions
Copy link

Remember to squash merge!

@github-actions GitHub Actions
Copy link

🔍Version Validation Results:

Comparing versions and changelogs for pipelines that differ from the versions on 'origin/staging':
MultiSampleSmartSeq2SingleNucleus.wdl has not been changed and needs updating
SlideSeq.wdl has not been changed and needs updating
PairedTag.wdl has not been changed and needs updating
Multiome.wdl has not been changed and needs updating
Some WDLs or changelog files need updating. See output for details.
validation_failed

@github-actions GitHub Actions
Copy link

🔍Changelog Validation Results:

Comparing changelogs for pipelines that differ from the versions on 'origin/develop':
MultiSampleSmartSeq2SingleNucleus.changelog.md has not been changed and needs to be updated
SlideSeq.changelog.md has not been changed and needs to be updated
PairedTag.changelog.md has not been changed and needs to be updated
Multiome.changelog.md has not been changed and needs to be updated
Some changelog files need updating. See output for details.
validation_failed

1 similar comment
@github-actions GitHub Actions
Copy link

🔍Changelog Validation Results:

Comparing changelogs for pipelines that differ from the versions on 'origin/develop':
MultiSampleSmartSeq2SingleNucleus.changelog.md has not been changed and needs to be updated
SlideSeq.changelog.md has not been changed and needs to be updated
PairedTag.changelog.md has not been changed and needs to be updated
Multiome.changelog.md has not been changed and needs to be updated
Some changelog files need updating. See output for details.
validation_failed

@github-actions GitHub Actions
Copy link

🔍Version Validation Results:

Comparing versions and changelogs for pipelines that differ from the versions on 'origin/staging':
MultiSampleSmartSeq2SingleNucleus.wdl has not been changed and needs updating
SlideSeq.wdl has not been changed and needs updating
PairedTag.wdl has not been changed and needs updating
Multiome.wdl has not been changed and needs updating
Some WDLs or changelog files need updating. See output for details.
validation_failed

@github-actions GitHub Actions
Copy link

Remember to squash merge!

@github-actions GitHub Actions
Copy link

🔍Changelog Validation Results:

Comparing changelogs for pipelines that differ from the versions on 'origin/develop':
MultiSampleSmartSeq2SingleNucleus.changelog.md has not been changed and needs to be updated
SlideSeq.changelog.md has not been changed and needs to be updated
PairedTag.changelog.md has not been changed and needs to be updated
Multiome.changelog.md has not been changed and needs to be updated
Some changelog files need updating. See output for details.
validation_failed

@github-actions GitHub Actions
Copy link

🔍Version Validation Results:

Comparing versions and changelogs for pipelines that differ from the versions on 'origin/staging':
MultiSampleSmartSeq2SingleNucleus.wdl has not been changed and needs updating
SlideSeq.wdl has not been changed and needs updating
PairedTag.wdl has not been changed and needs updating
Multiome.wdl has not been changed and needs updating
Some WDLs or changelog files need updating. See output for details.
validation_failed

@ekiernan ekiernan closed this Jun 28, 2024
@ekiernan ekiernan reopened this Jun 28, 2024
@github-actions GitHub Actions
Copy link

Remember to squash merge!

1 similar comment
@github-actions GitHub Actions
Copy link

Remember to squash merge!

@github-actions GitHub Actions
Copy link

🔍Version Validation Results:

Comparing versions and changelogs for pipelines that differ from the versions on 'origin/staging':
PairedTag.wdl has not been changed and needs updating
Some WDLs or changelog files need updating. See output for details.
validation_failed

@github-actions GitHub Actions
Copy link

🔍Changelog Validation Results:

Comparing changelogs for pipelines that differ from the versions on 'origin/develop':
All changelog files are valid for this release.

1 similar comment
@github-actions GitHub Actions
Copy link

🔍Changelog Validation Results:

Comparing changelogs for pipelines that differ from the versions on 'origin/develop':
All changelog files are valid for this release.

@github-actions GitHub Actions
Copy link

🔍Version Validation Results:

Comparing versions and changelogs for pipelines that differ from the versions on 'origin/staging':
PairedTag.wdl has not been changed and needs updating
Some WDLs or changelog files need updating. See output for details.
validation_failed

@github-actions GitHub Actions
Copy link

Remember to squash merge!

@github-actions GitHub Actions
Copy link

🔍Version Validation Results:

Comparing versions and changelogs for pipelines that differ from the versions on 'origin/staging':
All WDLs and changelog files appear to be valid for this release.

@github-actions GitHub Actions
Copy link

🔍Changelog Validation Results:

Comparing changelogs for pipelines that differ from the versions on 'origin/develop':
All changelog files are valid for this release.

@github-actions GitHub Actions
Copy link

Remember to squash merge!

@github-actions GitHub Actions
Copy link

🔍Changelog Validation Results:

Comparing changelogs for pipelines that differ from the versions on 'origin/develop':
All changelog files are valid for this release.

@github-actions GitHub Actions
Copy link

🔍Version Validation Results:

Comparing versions and changelogs for pipelines that differ from the versions on 'origin/staging':
All WDLs and changelog files appear to be valid for this release.

@nikellepetrillo
Copy link
Contributor

@ekiernan looks good! is this new docker in azure as well?

@github-actions GitHub Actions
Copy link

github-actions bot commented Jul 1, 2024

Remember to squash merge!

@github-actions GitHub Actions
Copy link

github-actions bot commented Jul 1, 2024

🔍Version Validation Results:

Comparing versions and changelogs for pipelines that differ from the versions on 'origin/staging':
All WDLs and changelog files appear to be valid for this release.

@github-actions GitHub Actions
Copy link

github-actions bot commented Jul 1, 2024

🔍Changelog Validation Results:

Comparing changelogs for pipelines that differ from the versions on 'origin/develop':
All changelog files are valid for this release.

@ekiernan
Copy link
Contributor Author

ekiernan commented Jul 1, 2024

@ekiernan looks good! is this new docker in azure as well?

It should have auto-built and pushed to ACR from warp-tools

@ekiernan ekiernan merged commit 4c62783 into develop Jul 1, 2024
12 checks passed
@ekiernan ekiernan deleted the lk-PD-2653-add-multiome-metrics branch July 1, 2024 12:34
@ekiernan ekiernan restored the lk-PD-2653-add-multiome-metrics branch July 1, 2024 12:36
@ekiernan ekiernan deleted the lk-PD-2653-add-multiome-metrics branch September 25, 2024 17:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@khajoue2 khajoue2 khajoue2 approved these changes

@nikellepetrillo nikellepetrillo nikellepetrillo approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ekiernan @nikellepetrillo @khajoue2