Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add --only-remove flag #44

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Conversation

hanoii
Copy link
Contributor

@hanoii hanoii commented May 12, 2017

No description provided.

@brock
Copy link
Owner

brock commented May 18, 2017

Thanks so much for creating a pull request! You are an awesome person, and you should feel good about yourself!! 😄 On to the PR...

I'm okay with the concept of adding an option for --only-remove, but when I tested this, the prompts felt just like the node-reinstall prompts, and I could imagine a new user feeling confused. I think this task deserves it's own prompts so that the user knows exactly what they are getting.

Here's an example. For a new user trying to uninstall node, this might be confusing:
screen shot 2017-05-17 at 7 37 55 pm

This made it look like we were going to re-install Node.js, even though we'd explicitly said --only-remove.

If we go this route, I think we should move the remove functionality into a separate function and make it a little more clear that we aren't going to re-install node or npm. That way we could do more customized messaging to the user so they know this is just a wipe without a re-install.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants