Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[...] @brodybits involvement with tvOS support #127

Closed
brodycj opened this issue Sep 16, 2019 · 5 comments
Closed

[...] @brodybits involvement with tvOS support #127

brodycj opened this issue Sep 16, 2019 · 5 comments
Assignees

Comments

@brodycj
Copy link
Owner

brodycj commented Sep 16, 2019

This information in response to a question I received by email:

tvOS was contributed in PR #91, and I have tested it with and without using the --view option for custom view (see discussion in #95 for more details)

I have also raised react-native-tvos/react-native-tvos#15 to get an idea of the amount users, developers, and commercial interest with tvOS may be out there.

In case of any troubles please raise a new issue with the exact commands and steps that can demonstrate the failure.

Private, high-priority commercial support is available from: https://xpbrew.consulting/

/cc @dlowder-salesforce

@brodycj brodycj self-assigned this Sep 16, 2019
brodycj pushed a commit that referenced this issue Nov 15, 2019
* doc fixes for tvOS platform fork (quick fixes)

* document tvOS platform "with limited if any active support from ... @brodybits"

* add reference to issue #127 for @brodybits involvement with tvOS support
@douglowder
Copy link
Collaborator

Just tested with react-native-tvos@0.61.2-0 and things seem to work well, once the example Podfile was updated for RN 0.61.

@brodycj
Copy link
Owner Author

brodycj commented Nov 15, 2019

[...] once the example Podfile was updated for RN 0.61.

Thanks for the update. Would you mind sharing any pointers for TV amateurs such as myself?

@douglowder
Copy link
Collaborator

Sure! I used create-react-native-module 0.11.1 as follows:

create-react-native-module test-module --author-name "Douglas Lowder" --author-email "dlowder@salesforce.com" --license MIT --view --use-cocoapods --generate-example --example-name moduleExample --example-react-native-version react-native@npm:react-native-tvos@0.61.2-0

Then I copied in the Podfile from the react-native-tvos template folder (https://github.com/react-native-community/react-native-tvos/blob/tvos-v0.61.2/template/ios/Podfile) to the example project ios directory, modifying the target names in the Podfile to match the example project.

@brodycj
Copy link
Owner Author

brodycj commented Nov 15, 2019

Then I copied in the Podfile from the react-native-tvos template folder (https://github.com/react-native-community/react-native-tvos/blob/tvos-v0.61.2/template/ios/Podfile) to the example project ios directory

Interesting, thanks. This sounds like something that should be done by react-native-cli itself, right?

Can you think of anything else that I or we may be missing here?

@douglowder
Copy link
Collaborator

Not at the moment... the Podfile is the only issue I hit. I can take a look at how it's generated -- seems like it should be coming from the template directory in whatever RN version is chosen for the example....

@brodycj brodycj closed this as completed May 11, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants