consistent iOS method spacing in generated code #148
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* continue using tabs in case of `useCocoapods: true` * with 4 spaces in case of no truthy `useCocoapods` option with a comment removed in case of `useCocoapods: true`
…tive-module into fix-ios-method-spacing
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
useAppleNetworking: trueuseAppleNetworkingoptionwith a comment removed in case of
useAppleNetworking: trueTesting
npm t(npm test) okNot testing these:
generate a new module with an example that works on iOS with--use-cocoapodsoptiongenerate a new module with an example that works on iOS with no--use-cocoapodsoptiongenerate a new view module with an example that works on iOS (--use-cocoapodsoption should not matter for a view module)generate a new module with an example that works on Apple tvOS (using the react-native-tvos fork) with--use-cocoapodsoptiongenerate a new module with an example that works on Apple tvOS (using the react-native-tvos fork) with no--use-cocoapodsoptiongenerate a new view module with an example that works on Apple tvOS (using the react-native-tvos fork)/cc @timojaask @dlowder-salesforce