[BREAKING] replace --use-cocoapods with 2 options #167
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
(extra example/ios/Podfile artifact no longer generated) as that example Podfile artifact is not expected to work with recent framework and tool updates and with an outdated DEFAULT constant removed, as it is not really needed and with CLI error logging test snapshot updated (due to the effect on the stack trace)
added 3 commits
November 14, 2019 21:50
…e-module into with-renamed-option-for-apple-networking
…plePodfile option (with trailing tabs removed)
brodycj
changed the title
brodycj
changed the title
brodycj
changed the title
|
Now merged, with commit message updated according to the updated title & description of this PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
replace
--use-cocoapodswith--use-apple-networking&--write-example-podfilepod install, with a comment depending on use of--write-example-podfileor notThis proposal should be considered a BREAKING CHANGE, for a 0.x minor release as opposed to a patch release.
This is a followup to PR #166 (update description to match the reality), in response to issue #155.
Resolves #145 (rename
--use-cocoapodsoption).TODO items:
For future consideration, outside this PR:
pod installpart so that this step can be removed from the generated message ref: fix generated iOS example on React Native 0.60(+) #99