-
Notifications
You must be signed in to change notification settings - Fork 52
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Gradle updates in android.js #24
Changes from 1 commit
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change | ||||
---|---|---|---|---|---|---|
|
@@ -12,7 +12,7 @@ module.exports = platform => [{ | |||||
dependencies { | ||||||
// Matches recent template from React Native (0.59) | ||||||
// https://github.com/facebook/react-native/blob/0.59-stable/template/android/build.gradle#L16 | ||||||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more.
Suggested change
(please double-check that my change to the link is correct) |
||||||
classpath("com.android.tools.build:gradle:${safeExtGet('gradlePluginVersion', '3.4.1')}") | ||||||
classpath("com.android.tools.build:gradle:$\{safeExtGet('gradlePluginVersion', '3.4.1')\}") | ||||||
SaeedZhiany marked this conversation as resolved.
Show resolved
Hide resolved
|
||||||
} | ||||||
} | ||||||
|
||||||
|
@@ -52,7 +52,7 @@ repositories { | |||||
} | ||||||
|
||||||
dependencies { | ||||||
implementation "com.facebook.react:react-native:${safeExtGet('reactnativeVersion', '+')}" | ||||||
implementation "com.facebook.react:react-native:$\{safeExtGet('reactnativeVersion', '+')\}" | ||||||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. @SaeedZhiany - I'm curious to understand in which case this would be used? The version of There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Hi @friederbluemle, yeah you're right. I just think having more control over all version used in the sub-modules could be great. currently, also if you open your project in android studio (open the android folder), you can see that android studio shows warning about nondeterministic package version usage in app's gradle file in However, I understand your point and agree with it, we can just ignore the warning and let the package manager solve the RN version. if you and @brodybits believe it has no more real usage than I mentioned, we can just revert it. There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Thanks for the explanation and for your work! :) There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Thank you,
Exactly and that's the reason I agree to revert it to
in which projects? can you give a link, please? And finally, what do you think? should we revert it? I'm ready to submit a PR again. There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Also please join this conversation and help us to find a way to manage androidX packages' version in the main project. the result of the conversation would be helpful for this repository too. |
||||||
} | ||||||
|
||||||
def configureReactNativePom(def pom) { | ||||||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.