add PR merge action #296
Merged
add PR merge action #296
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
brodycj
added a commit
that referenced
this pull request
Apr 8, 2020
This reverts commit 9712d41. Rationale: I do not have a very good feeling that this GitHub action works 100% correctly and securely. For future reconsideration.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://github.com/marketplace/actions/pull-request-merge-command
to pull & test from master before merging a PR
General motivation:
It is safest to pull and test from master before merging a PRGitHub should test this automatically, doesn't hurt to pull from master before merging though.I did test this action on my own scratch project, hope it will work as expected on this one.