[WIP] Move default values in build.gradle for Android DRAFT WIP 1 - NOT WORKING #31
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- move defaults from React Native 0.58 to the beginning - Android Gradle plugin version from RN 0.58 in the beginning - with some comments in the beginning
|
closing as outdated |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I tried to refactor the defaults all into one place back in April, did not seem to work for me.
These are old values, which have since been updated for React Native 0.59. This is also missing the enhancements proposed in PR #24…
I am raising this PR in hopes that someone can help me get this working.
/cc @SaeedZhiany