Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add swift search paths to iOS pbxproj #349

Merged
merged 2 commits into from
May 10, 2020

Conversation

brodycj
Copy link
Owner

@brodycj brodycj commented May 8, 2020

for consistency with React Native 0.62-stable / 0.63-stable template

from facebook/react-native@8f93dedc / facebook/react-native#27922

brodycj and others added 2 commits May 8, 2020 00:45
(should be consistent with React Native 0.62-stable & 0.63-stable)

from react-native commit id: 8f93dedc (react-native PR #27922)

Co-authored-by: Eloy Durán <eloy.de.enige@gmail.com>
Co-authored-by: Christopher J. Brody <chris.brody+brodybits@gmail.com>
@brodycj brodycj self-assigned this May 8, 2020
@brodycj brodycj marked this pull request as ready for review May 10, 2020 23:32
Copy link
Owner Author

@brodycj brodycj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested together with PR #348 for:

  • native module & native view with react-native 0.60 on Android & iOS
  • native module & native view with react-native-tv 0.60 on Android, iOS, tvOS
  • native module & native view with react-native 0.61 on Android & iOS
  • native module & native view with react-native-tv 0.61 on Android, iOS, tvOS
  • native module & native view with react-native 0.62 on Android & iOS
  • native module & native view with react-native-tv 0.62 on Android, iOS, tvOS
  • native module & native view with react-native 0.63 RC on Android & iOS

@brodycj brodycj merged commit beca298 into master May 10, 2020
@brodycj brodycj deleted the add-swift-search-paths-to-ios-pbxproj branch May 10, 2020 23:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant