cleanup internal updatePlatformInFile function in templates/index.js #64
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
in templates/index.js * line break * do not overwrite object from another module in Object.assign() call as such an overwrite is not needed and is not good form
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
in templates/index.js
Object.assign()call, as such an overwrite is not needed and is not good formTesting done:
npm test(equivalent toyarn test) succeeds in my work areaNote that I think there is no need to do manual integration testing of the CLI, as the existing tests verify that changes to
templates/*.jsdo not break anything.Discovered while working on some cleanup related to evaluating use of my
prettierxfork of Prettier (#5).