-
-
Notifications
You must be signed in to change notification settings - Fork 14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add HSTSRedirection Middleware #23
Conversation
Is the pull request's check failing for anything I'm doing wrong? I thought it was because the warning but I've already fix it. Thank you very much and sorry for the inconvenience. |
I don't think so, have reran them to see. Also, thanks for this PR! Just to say I've seen it, am very grateful and haven't forgotten! Will take a look over the holiday break in the coming days |
Good morning Tim,
Thank you very much, It’s an honor to contribute to one of your projects. I tried to modify the existing work as little as possible. If you need anything to be changed, please don’t hesitate to notify me.
Have a nice day!
Sincerely,
Mattia
El 21 dic 2020, a las 9:01, Tim Condon <notifications@github.com> escribió:
I don't think so, have reran them to see.
Also, thanks for this PR! Just to say I've seen it, am very grateful and haven't forgotten! Will take a look over the holiday break in the coming days
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub<#23 (comment)>, or unsubscribe<https://github.com/notifications/unsubscribe-auth/AKGVLAXMWIX5RJCUMQLVHHDSV4FHFANCNFSM4VAE47VQ>.
|
@Mattiav8 ah I know what the problem is and it's nothing you've done. Installing packages changed a few months ago. Quickest way to fix this would be to change this line https://github.com/brokenhandsio/VaporSecurityHeaders/blob/master/.github/workflows/ci.yml#L22 to run: apt-get update && apt-get install curl -y The |
Yes, but I could do it this afternoon if you agree with it. |
Codecov Report
@@ Coverage Diff @@
## master #23 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 10 11 +1
Lines 213 226 +13
=========================================
+ Hits 213 226 +13
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for this! Looks really good! Just a couple of small tweaks before it can be merged
Sources/VaporSecurityHeaders/Configurations/HSTSRedirectMiddleware.swift
Outdated
Show resolved
Hide resolved
Thank you Tim. I modified the code as requested. Comments were right and sorry not to think about it before. If you need anything else, I'm at your disposal. Thank you very much! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
Hello Tim,
I'd like to show you a little implementation for http/https redirection. Please be free to give me any feedback (good or bad) and don't hesitate to tell me if anything is wrong or needs to be changed.
Thank you very much for your disposal, I really appreciate it.