Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

change "audio/mp4" to "audio/x-m4a" #146

Closed
wants to merge 1 commit into from

Conversation

MylesBorins
Copy link

This has been changed in mime-db and is causing test failures

This has been changed in mime-db and is causing test failures
@MylesBorins
Copy link
Author

you may want to take only the test change... but this is currently broken on every version of node on every major platform we smoke test

disclaimer: I work on node core... specifically around ecosystem stability and smoketesting

@broofa
Copy link
Owner

broofa commented May 7, 2016

Thanks for the heads up.

I'm inclined to say that audio/mp4 is the "more correct" mapping here. 'Looks like what happened is that nginx added the audio/x-m4a definition to their types file, which mime-db picked up and which now conflicts with the audio/mp4 definition from Apache uses.

Rather than patch the test and types.json file, I think it makes more sense to change build.js so it prioritizes official types over experimental ones when building types.json.

Thoughts?

@MylesBorins
Copy link
Author

@broofa that sounds like a reasonable idea. I dug through the code and it looks like what is happening is that dupes are overwriting. It seems to be like this change will be non-trivial, and might have some performance implications if it is not done in the db parsing stage.

Thoughts?

@MylesBorins
Copy link
Author

ping @broofa

@broofa
Copy link
Owner

broofa commented May 11, 2017

Will be closed in #156

@broofa broofa closed this May 11, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants