Add model attributes #212
Add model attributes #212
Conversation
| @@ -34,3 +34,5 @@ | |||
|
|
|||
| {%- endmacro %} | |||
|
|
|||
| {% macro default__insert_into_metadata_table(database_name, schema_name, table_name, content) -%} | |||
| {%- endmacro %} | |||
There was a problem hiding this comment.
Is this needed @ahmedrad ?
There was a problem hiding this comment.
we have a project that uses both redshift and snowflake connectors. the dbt artifacts hooks and models are only enabled on snowflake via the config but the compilation throws an error all together because this default method was missing. i dont think its a graceful way to fail on an unsupported connector and I cant find another way to install the package on a project that has some redshift models without failing compilation. open to other suggestions though!
There was a problem hiding this comment.
Makes total sense @ahmedrad ! Thanks for explaining.
|
Thank you @ahmedrad! |
| cast(null as {{ type_string() }}) as materialization | ||
| cast(null as {{ type_string() }}) as materialization, | ||
| cast(null as {{ type_array() }}) as tags, | ||
| cast(null as {{ type_json() }}) as meta |
There was a problem hiding this comment.
@NiallRees I'm not sure what the linter is complaining about, I can't see any trailing whitespace on those lines!
There was a problem hiding this comment.
@ahmedrad There is a bug with SQLFluff atm for L001 - sqlfluff/sqlfluff#3851 - We managed to fix by reverting to 1.2.1.
|
@NiallRees Apologies, I am naive to releases / working from main branch - will there be a release for this commit or how does it work normally? |
Hi @jelstongreen, that's all good! We'll aim to get another release out this week which will include the commit, and that will make it available via the dbt hub. If you want it straight away though, you can always use this in your packages.txt: |
Adding more attributes to the models (meta and tags fields from the manifest)