-
Notifications
You must be signed in to change notification settings - Fork 128
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add meta to seeds/snapshots #237
Merged
NiallRees
merged 4 commits into
brooklyn-data:main
from
nhrebinka:add_meta_to_seeds_snapshots
Nov 2, 2022
Merged
Add meta to seeds/snapshots #237
NiallRees
merged 4 commits into
brooklyn-data:main
from
nhrebinka:add_meta_to_seeds_snapshots
Nov 2, 2022
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nhrebinka
commented
Nov 1, 2022
@@ -14,6 +14,7 @@ select | |||
cast(null as {{ type_string() }}) as package_name, | |||
cast(null as {{ type_string() }}) as path, | |||
cast(null as {{ type_string() }}) as checksum, | |||
cast(null as {{ type_string() }}) as strategy | |||
cast(null as {{ type_string() }}) as strategy, | |||
cast(null as {{ type_json() }}) as meta |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@NiallRees this is some kind of a bug, there is no trailing whitespace in these two files. SQLFluff lints them OK for me locally. Could you pls take a look?
robertholmes3
pushed a commit
to robertholmes3/dbt_artifacts
that referenced
this pull request
Nov 2, 2022
* add meta to seeds/snapshots * remove quotes - bigquery * add parse_json * type_array -> type_json
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is to add meta to seeds and snapshots. I tested it on our huge monorepo, works fine and the dims are pulling the right meta fields.